Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct outdated documentation for rc::Weak #84220

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Correct outdated documentation for rc::Weak #84220

merged 1 commit into from
Apr 16, 2021

Conversation

gpluscb
Copy link
Contributor

@gpluscb gpluscb commented Apr 15, 2021 •
edited
Loading

This was overlooked in #50357 #51901

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 15, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 15, 2021

📌 Commit 288bd49 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2021
@jyn514 jyn514 added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 15, 2021
@bors
Copy link
Contributor

bors commented Apr 15, 2021

⌛ Testing commit 288bd49 with merge c7dbecccb4b4f040e8ade7f4aa02a541cb4e922e...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Attempting with retry: docker build --rm -t rust-ci -f /home/runner/work/rust/rust/src/ci/docker/host-x86_64/dist-i686-linux/Dockerfile /home/runner/work/rust/rust/src/ci/docker
Sending build context to Docker daemon  494.1kB

Step 1/36 : FROM debian:6
received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  494.1kB

Step 1/36 : FROM debian:6
Step 1/36 : FROM debian:6
received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  494.1kB

Step 1/36 : FROM debian:6
Step 1/36 : FROM debian:6
received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  494.1kB

Step 1/36 : FROM debian:6
Step 1/36 : FROM debian:6
received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  494.1kB

Step 1/36 : FROM debian:6
Step 1/36 : FROM debian:6
received unexpected HTTP status: 503 Service Unavailable
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Apr 15, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2021
@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2021
@bors
Copy link
Contributor

bors commented Apr 16, 2021

⌛ Testing commit 288bd49 with merge 5e7beba...

@bors
Copy link
Contributor

bors commented Apr 16, 2021

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 5e7beba to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2021
@bors bors merged commit 5e7beba into rust-lang:master Apr 16, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 16, 2021
@gpluscb gpluscb deleted the weak_doc branch April 16, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
7 participants
@gpluscb @rust-highfive @jyn514 @bors @rust-log-analyzer @Mark-Simulacrum @rustbot